Skip to content

Restrict rand::rngs::adapter to std#1027

Merged
vks merged 1 commit into
rust-random:masterfrom
vks:restrict-reseeding
Aug 28, 2020
Merged

Restrict rand::rngs::adapter to std#1027
vks merged 1 commit into
rust-random:masterfrom
vks:restrict-reseeding

Conversation

@vks

@vks vks commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

See #911.

@dhardy I'm not sure whether more changes were intended?

@vks vks requested a review from dhardy August 28, 2020 14:32
@vks vks mentioned this pull request Aug 28, 2020
19 tasks

@dhardy dhardy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten about that. Sure, this looks good!

@dhardy

dhardy commented Aug 28, 2020

Copy link
Copy Markdown
Member

@vks could you check the docs locally before merging (the cfg thing)? Looks like it will be fine.

@vks

vks commented Aug 28, 2020

Copy link
Copy Markdown
Contributor Author

@dhardy Are you referring to #[cfg_attr(doc_cfg, doc(cfg(feature = "std")))]? I do not how to invoke rustdoc so that this gets used.

@dhardy

dhardy commented Aug 28, 2020

Copy link
Copy Markdown
Member

It's in the Cargo.toml:

RUSTDOCFLAGS="--cfg doc_cfg" cargo +nightly doc --all-features --no-deps --open

@vks

vks commented Aug 28, 2020

Copy link
Copy Markdown
Contributor Author

This works as intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants